Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to last three version #1

Open
lo-th opened this issue Jan 26, 2024 · 4 comments
Open

update to last three version #1

lo-th opened this issue Jan 26, 2024 · 4 comments

Comments

@lo-th
Copy link

lo-th commented Jan 26, 2024

hello nice project here a update to last three js version
enhanceShaderLighting.zip

@arpu
Copy link

arpu commented Feb 1, 2024

what is the diff?

@lo-th
Copy link
Author

lo-th commented Feb 2, 2024

not many
geometry.viewDir is geometryViewDir ...
and no more need vUv2 each map can have her own uv

@lo-th
Copy link
Author

lo-th commented Feb 15, 2024

finally i find what wrong in conversion :)
code is good but three need some adjustment to keep same look
renderer should use LegacyLights ( default is now false )
renderer.useLegacyLights = true;
and all color should not use colorSpace
options.aoColor.setHex(0x4d4f3b, THREE.NoColorSpace )
and lightMap
lightMap.colorSpace = THREE.NoColorSpace;

light1

@lo-th
Copy link
Author

lo-th commented Feb 16, 2024

ok find a way to avoid renderer.useLegacyLights = true;
because is "has been deprecated"
only have to change lightMapIntensity / PI
by lightMapIntensity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants