Min brightness support

[JasperSnowolf]

Hey there!

I have some Geeni bulbs I'm trying to control. I am able to do everything except turn them off (turning on works, and setting brightness). When I go to turn them off, I get an "Invalid Parameter" message. This seems to be because the min brightness value for these bulbs is 9, so any attempt to set a lower value fails. It looks like this also causes the Characteristic.On update to fail to since they are sent in the same request.

I was able to fix this in my case by editing the LightAccessory.ts file and adding a check on the brightness value before it is updated. So if the value was going to be set to a value less than 9, it skipped the update.

If this capability already exists through some configuration, let me know! If not, it would be useful to be able to configure a min/max brightness setting for each device.

Update:
I added some logic to incorporate a min value into the configureBrightness() method. This will rescale the onSet/onGet values correctly:

    configureBrightness() {
        const service = this.getLightService();
        service.getCharacteristic(this.Characteristic.Brightness)
            .onGet(() => {
            var _a;
            // Color mode, get brightness from hsv
            if (this.inColorMode()) {
                const { max } = ((_a = this.getColorSchema()) === null || _a === void 0 ? void 0 : _a.prope>
                const status = this.getColorValue().v;
                let value = Math.floor(100 * status / max);
                value = Math.max(0, value);
                value = Math.min(100, value);
                return value;
            }
            const schema = this.getBrightnessSchema();
            const { max } = schema.property;
            const min = 25;
            const status = this.getStatus(schema.code);
            let value = Math.ceil(100 * (status.value - min) / (max - min));
            value = Math.max(0, value);
            value = Math.min(100, value);
            return value;
        })
            .onSet((value) => {
            var _a;
            this.log.debug(`Characteristic.Brightness set to: ${value}`);
            // Color mode, set brightness to hsv
            if (this.inColorMode()) {
                const { max } = ((_a = this.getColorSchema()) === null || _a === void 0 ? void 0 : _a.prope>
                const colorSchema = this.getColorSchema();
                const colorValue = this.getColorValue();
                colorValue.v = Math.floor(value * max / 100);
                this.sendCommands([{ code: colorSchema.code, value: JSON.stringify(colorValue) }], true);
                return;
            }
            const brightSchema = this.getBrightnessSchema();
            const { max } = brightSchema.property;
            const min = 25;
            const brightValue = min + Math.floor(value * (max - min) / 100);
            this.sendCommands([{ code: brightSchema.code, value: brightValue }], true);
        });
    }

[0x5e]

Thanks @JasperSnowolf , yes I'm not process properly currently.

We can get brightness property via this.getBrightnessSchema().property, as it's a integer type, property has min, max, scale, step, which describes your device's brightness value.

Some light maybe min=10, max=1000, some maybe min=1, max=100. As we can infer, whatever the unit it is, 0 always means no brightness at all. But why some min != 0? I think it's because the limitation of the light's accuracy, they are not able to set a very very small brightness.

So we should remap 0%~100% to 0~max instead of 0%~100% to min~max.

And we can use service.setProps() to change the light accessory's minValue. Then we can't slide the brightness lower than min (not tested yet)

Would you like to help me fixing it? Thanks a lot :)

[0x5e]

Update:
Some light has color and white mode so setProps may complicated during the switch. The two mode has different brightness value.
I add a check if value is small than min then send min instead, if just drop the value and the value was 100% before, it will sounds like a bug more than send a min value.

[0x5e]

Updated in #63 . Please try beta.28

[JasperSnowolf]

This update works for me! Yea, thats a better solution then skipping the update. Thanks!