Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(log): store log in context so it's automatically propagated #1356

Merged
merged 6 commits into from
Mar 19, 2024

refactor: remove `model.Request.Log` in favor of use `Context`

7d8f30f
Select commit
Loading
Failed to load commit list.
Merged

refactor(log): store log in context so it's automatically propagated #1356

refactor: remove `model.Request.Log` in favor of use `Context`
7d8f30f
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Mar 19, 2024 in 1s

94.24% (+0.35%) compared to fe84ab8

View this Pull Request on Codecov

94.24% (+0.35%) compared to fe84ab8

Details

Codecov Report

Attention: Patch coverage is 88.88889% with 21 lines in your changes are missing coverage. Please review.

Project coverage is 94.24%. Comparing base (fe84ab8) to head (7d8f30f).
Report is 36 commits behind head on main.

Files Patch % Lines
server/server_endpoints.go 60.00% 5 Missing and 1 partial ⚠️
resolver/caching_resolver.go 66.66% 5 Missing ⚠️
resolver/parallel_best_resolver.go 60.00% 3 Missing and 1 partial ⚠️
resolver/query_logging_resolver.go 40.00% 3 Missing ⚠️
server/server.go 94.91% 2 Missing and 1 partial ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1356      +/-   ##
==========================================
+ Coverage   93.88%   94.24%   +0.35%     
==========================================
  Files          78       78              
  Lines        6361     4933    -1428     
==========================================
- Hits         5972     4649    -1323     
+ Misses        300      194     -106     
- Partials       89       90       +1

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

View more details on Codecov