feat: Implement ReorgDetector V2 #34
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
begmaroman
changed the title
# Conflicts: # cmd/run.go # reorgdetector/mock_eth_client.go
begmaroman
changed the title
arnaubennassar
requested changes
Aug 21, 2024
# Conflicts: # aggoracle/e2e_test.go # cmd/run.go # reorgdetector/reorgdetector.go # reorgdetector/reorgdetector_test.go
arnaubennassar
requested changes
Aug 21, 2024
| "github.com/stretchr/testify/require" | ||
| ) | ||
|
|
||
| func TestBlockMap(t *testing.T) { |
There was a problem hiding this comment.
Suggested change
| func TestBlockMap(t *testing.T) { | |
| func TestHeadersList(t *testing.T) { |
arnaubennassar
requested changes
Aug 26, 2024
| trackedBlocks[string(k)] = newBlockMap(blocks...) | ||
| } | ||
| // Update the tracked blocks in the DB | ||
| if err := rd.updateTrackedBlocksDB(ctx, id, hdrs); err != nil { |
There was a problem hiding this comment.
I don't understand why this is needed? Is it possible that is a left over from refactoring?
Update: understood, that the update is meant to delete in case the hdrs map removed some entities. It's a bit counter intuitive that this doesn't happen while doing the deletes, but being able to do it on the deletion would complicate the DB handling. LGTM, maybe in the future we move to SQLite and can improve this
arnaubennassar
approved these changes
Aug 27, 2024
goran-ethernal
approved these changes
Aug 27, 2024
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.