You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I suggest passing the library from the Miden package as LinkedLibrary(via --linked-lib) to the midenc.
This would require to add LinkedLibrary::Masp variant that would parse the Package from the masp file and extract CompiledLibrary out of it.
Since LinkLibrary is in the midenc-session crate and Package is in midenc-codegen-masm crate, there is no way of parsing the Package in LinkLibrary impl. So we would need to re-arrange Package and/or LinkLibrary. Package seems to be destined to be in its own midenc-package crate. So I'd start there. Given that PackageManifest::link_libraries uses LinkLibrary they might end up in the same crate.
EDIT: Following our discussion, the miden-package crate with Package type should be created in the vm repo.
The content you are editing has changed. Please copy your edits and refresh the page.
I suggest passing the library from the Miden package as
LinkedLibrary
(via--linked-lib
) to the midenc.This would require to add
LinkedLibrary::Masp
variant that would parse thePackage
from themasp
file and extractCompiledLibrary
out of it.Since
LinkLibrary
is in themidenc-session
crate andPackage
is inmidenc-codegen-masm
crate, there is no way of parsing thePackage
inLinkLibrary
impl. So we would need to re-arrangePackage
and/orLinkLibrary
.Package
seems to be destined to be in its ownmidenc-package
crate. So I'd start there. Given thatPackageManifest::link_libraries
usesLinkLibrary
they might end up in the same crate.EDIT: Following our discussion, the
miden-package
crate withPackage
type should be created in the vm repo.Tasks
The text was updated successfully, but these errors were encountered: