Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Option in Wasm frontend to remove hash in mangled function names (for golden tests) #41

Closed
greenhat opened this issue Oct 19, 2023 · 0 comments · Fixed by #46
Closed

Option in Wasm frontend to remove hash in mangled function names (for golden tests) #41

greenhat opened this issue Oct 19, 2023 · 0 comments · Fixed by #46
Labels
testing

Comments

@greenhat
Copy link
Contributor

greenhat commented Oct 19, 2023 •
edited
Loading

Extracted from #22 (comment)

The problem is that the expect! test for dlmalloc and signed_arith that checks the produced wat file fails on CI because hashes in mangled function names differ from the "golden"/expected ones that I built on my machine.
I'm thinking about cutting out the hash from the mangled name. It should be hidden behind the option.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Demangle function names in Rust compilation tests comparison 0xPolygonMiden/compiler
1 participant
@greenhat