feat: implement conversion of masm ir to 'real' masm #35
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greenhat
approved these changes
Oct 18, 2023
| let invoked = BTreeMap::from([(entry_id, (entry_name, entry_module_path))]); | ||
| let imports = ModuleImports::new(imported, invoked); | ||
|
|
||
| // TODO: Write data segments, initialize function table |
There was a problem hiding this comment.
Would an issue be a better fit for these tasks?
There was a problem hiding this comment.
I do have one for this, basically #32 describes the function table. The data segments I'm planning to revisit later this week or early next, so this is just a reminder that this location needs to handle those items when implemented. I my Emacs config makes use of comments like these to produce a navigable list of TODOs in the code that I use as a functional TODO list, so if you see comments like this, they don't just go into the ether :). That said, it's a good to remind me to create issues for these things, since sometimes I don't have immediate plans to address them.
bitwalker
force-pushed
the
bitwalker/emit-masm
branch
from
2ed978f
to
9cdf7f1
Compare
bitwalker
force-pushed
the
bitwalker/emit-masm
branch
from
9cdf7f1
to
cece54b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As the PR title states, this enables conversion from our internal MASM IR to the "real" MASM representation provided by the
miden-assemblycrate. We can then emit to disk using those APIs, compile via the assembler, or run with the Miden VM.NOTE: This PR omits a couple things pending some other work:
dynexecis on hold until Implement support for indirect calls via dynexec/procref #32 is implemented