Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

merkle module: remove obsolete structures #248

Closed
plafer opened this issue Jan 12, 2024 · 1 comment · Fixed by #257
Closed

merkle module: remove obsolete structures #248

plafer opened this issue Jan 12, 2024 · 1 comment · Fixed by #257
Assignees
@bobbinth
Milestone
v0.8

Comments

@plafer
Copy link
Contributor

plafer commented Jan 12, 2024 •
edited by bobbinth
Loading

We may be able to get rid of this whole file. Previously, it was used in miden-base, but after 0xPolygonMiden/miden-base#409, we might not need it any more. Let's create an issue for this.

Originally posted by @bobbinth in #245 (comment)

I think TryApplyDiff is another one of these obsolete things which we can probably remove. Let's add this to the issue I mentioned in the previous comment.

Originally posted by @bobbinth in #245 (comment)
@plafer plafer mentioned this issue Jan 12, 2024
Merged
7 tasks
@plafer plafer changed the title Consider removing src/merkle/delta.rs merkle module: remove obsolete structures Jan 12, 2024
@bobbinth bobbinth mentioned this issue Jan 19, 2024
Merged
@bobbinth bobbinth linked a pull request Jan 19, 2024 that will close this issue
Remove obsolete traits #257
Merged
@bobbinth bobbinth added this to the v0.8 milestone Jan 19, 2024
@bobbinth bobbinth self-assigned this Jan 21, 2024
@bobbinth
Copy link
Contributor

Closed by #257.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bobbinth bobbinth

Labels
None yet
Projects
Builder's testnet
Status: Done
Milestone
v0.8
Development

Successfully merging a pull request may close this issue.

Remove obsolete traits 0xPolygonMiden/crypto
2 participants
@plafer @bobbinth