Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Serializable for FungibleAsset #900

Closed
PhilippGackstatter opened this issue Sep 30, 2024 · 1 comment · Fixed by #907
Closed

Implement Serializable for FungibleAsset #900

PhilippGackstatter opened this issue Sep 30, 2024 · 1 comment · Fixed by #907
Assignees
@PhilippGackstatter
Labels
enhancement New feature or request
Milestone
v0.6

Comments

@PhilippGackstatter
Copy link
Contributor

What should be done?

Implement Serializable for FungibleAsset.

How should it be done?

Implement Serializable for FungibleAsset and consider changing how Asset is serialized by delegating to the implementation on FungibleAsset and NonFungibleAsset.

When is this task done?

This task is done when Serializable is implemented for FungibleAsset and Asset serialization has been reconsidered.

Additional context

No response
@PhilippGackstatter PhilippGackstatter added the enhancement New feature or request label Sep 30, 2024
@PhilippGackstatter PhilippGackstatter mentioned this issue Sep 30, 2024
Merged
@bobbinth bobbinth added this to the v0.6 milestone Oct 7, 2024
@PhilippGackstatter PhilippGackstatter linked a pull request Oct 7, 2024 that will close this issue
Implement Serializable for FungibleAsset #907
Merged
@bobbinth
Copy link
Contributor

Closed by #907.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@PhilippGackstatter PhilippGackstatter

Labels
enhancement New feature or request
Projects
User's testnet
Status: Done
Milestone
v0.6
Development

Successfully merging a pull request may close this issue.

Implement Serializable for FungibleAsset 0xPolygonMiden/miden-base
2 participants
@PhilippGackstatter @bobbinth