From 86a63480b90820895c5310f78cd6cfe45f2fee94 Mon Sep 17 00:00:00 2001 From: polydez <155382956+polydez@users.noreply.github.com> Date: Wed, 2 Oct 2024 11:44:01 +0500 Subject: [PATCH 1/2] refactor: move `MAX_NUM_FOREIGN_ACCOUNTS` into `miden-objects` --- miden-lib/src/transaction/memory.rs | 3 --- objects/src/constants.rs | 3 +++ 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/miden-lib/src/transaction/memory.rs b/miden-lib/src/transaction/memory.rs index b5b33cce5..2d8c43311 100644 --- a/miden-lib/src/transaction/memory.rs +++ b/miden-lib/src/transaction/memory.rs @@ -164,9 +164,6 @@ pub const KERNEL_PROCEDURES_PTR: MemoryAddress = 401; // ACCOUNT DATA // ------------------------------------------------------------------------------------------------ -/// Maximum number of the foreign accounts that can be loaded. -pub const MAX_NUM_FOREIGN_ACCOUNTS: u8 = 64; - /// The size of the memory segment allocated to core account data (excluding new code commitment) pub const ACCT_DATA_MEM_SIZE: MemSize = 4; diff --git a/objects/src/constants.rs b/objects/src/constants.rs index 4b7c9b9eb..8d020b3a9 100644 --- a/objects/src/constants.rs +++ b/objects/src/constants.rs @@ -28,6 +28,9 @@ pub const MAX_TX_EXECUTION_CYCLES: u32 = 1 << 30; /// The minimum number of VM cycles a transaction needs to execute. pub const MIN_TX_EXECUTION_CYCLES: u32 = 1 << 12; +/// Maximum number of the foreign accounts that can be loaded. +pub const MAX_NUM_FOREIGN_ACCOUNTS: u8 = 64; + // TRANSACTION BATCH // ================================================================================================ From 14ec65ef48afa5f8ed84fa1af019543884a05f70 Mon Sep 17 00:00:00 2001 From: polydez <155382956+polydez@users.noreply.github.com> Date: Wed, 2 Oct 2024 11:47:07 +0500 Subject: [PATCH 2/2] docs: update `CHANGELOG.md` --- CHANGELOG.md | 1 + 1 file changed, 1 insertion(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 1ee7be277..78fb6a0a3 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -19,6 +19,7 @@ - [BREAKING] `send_asset` procedure was removed from the basic wallet (#829). - [BREAKING] Updated limits, introduced additional limits (#889). - Introduced `AccountDelta` maximum size limit of 32 KiB (#889). +- [BREAKING] Moved `MAX_NUM_FOREIGN_ACCOUNTS` into `miden-objects` (#904). ## 0.5.1 (2024-08-28) - `miden-objects` crate only