feat: Add RemoteTransactionProver struct
#921
Conversation
There was a problem hiding this comment.
Looks good! Thank you! I left just a few small comments inline.
One other thing I was wondering: since this is not not just a pure binary - should it still be in the bin directory? Probably not something we need to address as a part of this PR, but maybe we should move it to a crates directory (together with other crates at the root level). Let's create an issue for this.
| [target.'cfg(all(target_arch = "wasm32", target_os = "unknown"))'.dependencies] | ||
| tonic-web-wasm-client = { version = "0.6", default-features = false } | ||
| tonic = { version = "0.12", default-features = false, features = ["prost", "codegen"] } | ||
| getrandom = { version = "0.2", features = ["js"], optional = true } | ||
|
|
||
| [target.'cfg(not(all(target_arch = "wasm32", target_os = "unknown")))'.dependencies] | ||
| tonic = { version = "0.12", default-features = false, features = ["prost", "codegen", "transport"] } |
There was a problem hiding this comment.
Question: does target_os = "unknown" basically mean any OS?
There was a problem hiding this comment.
If we wanted to mean any OS, we would not specify target_os (ie, [target.'cfg(all(target_arch = "wasm32"))'.dependencies]). I could be wrong, but I think target_os = "unknown" basically means any environment "without" OS. That is, for instance, for WASI environments this dependencies separator would not match. I added the target_os because of the tonic-web-wasm-client doc which mentions it supports this target explicity, but I think it would not matter much in practice if we removed it.
Adds
RemoteTransactionProverstruct to themiden-tx.