You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
While I think 0xPolygonMiden/crypto#288 could be independently interesting, I wonder if we should use a different approach for this specific issue.
This should help abstract away the logic of how block numbers are associated with nullifiers and would leave more flexibility for the future (e.g., we could build a specialized implementation of the NullifierTree which assumes that leaves are just 32-bit values).
How should it be done?
Specifically, we could create a new type NullifierDb or NullifierTree which would look something like this:
pubstructNullifierTree(Smt);implNullifierTree{pub add(&mutself,nullifier:Nullifier,block_num:u32)-> Result<(),NullifierTreeError>{// returns an error if the nullifier is already in the tree}pubfnget_block_num(&self,nullifier:&Nullifier) -> Option<u32>{// returns None if the nullifier is not in the tree}}
When is this task done?
When wrapper with requested functionality is implemented and all components of Miden Node use it for nullifier's tree instead of bare Smt with conversions of nullifier's data.
Node's components affected by this task
What should be done?
From @bobbinth:
How should it be done?
Specifically, we could create a new type
NullifierDb
orNullifierTree
which would look something like this:When is this task done?
When wrapper with requested functionality is implemented and all components of Miden Node use it for nullifier's tree instead of bare
Smt
with conversions of nullifier's data.Additional context
More context here: #266
The text was updated successfully, but these errors were encountered: