-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve the node & faucet logs #484
Comments
I think this is roughly how things work now, no? Basically, we use |
Correct; however these are just rough rules of thumb. The more accurate gauge is whether one cares about the error variants at all. Or put slightly differently - are our Semantic games aside though, we just need to ensure that we don't lose any important context along the way. Something like |
Hmm now that I've logged on to the actual instance, the logs provided initially seem to be truncated.
On site logs appear to be fine ito context so maybe this is a non-issue. Could be worth taking a look regardless. |
Related to #499. |
As evidenced in #483, our logs are missing useful context.
A lot of this context is going missing because we are using structured error enums which aren't encapsulating the inner error.
Common suggestion is to prefer
anyhow
for errors in an application as usually we don't care about the what, only that an error happened. For libs insteadthiserror
/structure errors are suggested but these are just guidelines.In general, we should use
anyhow
if we don't care to match on the exact error variant.The text was updated successfully, but these errors were encountered: