Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix build after SMT breaking changes #162

Merged
merged 13 commits into from
Jan 18, 2024
Merged

Fix build after SMT breaking changes #162

merged 13 commits into from
Jan 18, 2024

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Jan 18, 2024

Fixes build after 0xPolygonMiden/crypto#245

@plafer plafer requested a review from bobbinth January 18, 2024 20:48
bobbinth
bobbinth approved these changes Jan 18, 2024
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left a few comments inline - but they are basically the same comment just applied to different places.

block-producer/src/test_utils/block.rs Outdated Show resolved Hide resolved
block-producer/src/test_utils/block.rs Outdated Show resolved Hide resolved
block-producer/src/test_utils/store.rs Outdated Show resolved Hide resolved
block-producer/src/test_utils/store.rs Outdated Show resolved Hide resolved
block-producer/src/test_utils/store.rs Outdated Show resolved Hide resolved
store/src/state.rs Show resolved Hide resolved
store/src/state.rs Show resolved Hide resolved
@bobbinth bobbinth merged commit b0e4c87 into main Jan 18, 2024
3 of 4 checks passed
@bobbinth bobbinth deleted the plafer-smt-trait-breaking-change branch January 18, 2024 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@plafer @bobbinth