Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Return proper error message from the mem_ops in case of underflow #1372

Closed
Fumuran opened this issue Jul 2, 2024 · 1 comment · Fixed by #1379
Closed

Return proper error message from the mem_ops in case of underflow #1372

Fumuran opened this issue Jul 2, 2024 · 1 comment · Fixed by #1379
Assignees
@Fumuran

Comments

@Fumuran
Copy link
Contributor

Fumuran commented Jul 2, 2024

It is possible to have subtraction with underflow in the local_to_absolute_addr function (here) during the calculation of the addresses for the memory operation. Proper error message should be returned if this error occurs.

Original comment: #1371 (comment)
@Fumuran Fumuran self-assigned this Jul 2, 2024
@Fumuran Fumuran mentioned this issue Jul 3, 2024
Merged
@Fumuran Fumuran linked a pull request Jul 3, 2024 that will close this issue
Return proper message at underflow #1379
Merged
@bobbinth
Copy link
Contributor

bobbinth commented Jul 8, 2024

Closed by #1379.

@bobbinth bobbinth closed this as completed Jul 8, 2024
@bobbinth bobbinth mentioned this issue Jul 12, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fumuran Fumuran

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Return proper message at underflow 0xPolygonMiden/miden-vm
2 participants
@Fumuran @bobbinth