Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change u32assert2 error code type to u32 #1381

Closed
Fumuran opened this issue Jul 7, 2024 · 1 comment · Fixed by #1382
Closed

Change u32assert2 error code type to u32 #1381

Fumuran opened this issue Jul 7, 2024 · 1 comment · Fixed by #1382
Assignees
@Fumuran
Labels
assembly Related to Miden assembly

Comments

@Fumuran
Copy link
Contributor

Fumuran commented Jul 7, 2024

Currently u32assert2 operation uses Felt as a type of its error code. It should be changed to u32 since error code could be represented only by u32 value.
@Fumuran Fumuran added the assembly Related to Miden assembly label Jul 7, 2024
@Fumuran Fumuran self-assigned this Jul 7, 2024
@Fumuran Fumuran mentioned this issue Jul 8, 2024
Merged
@Fumuran Fumuran linked a pull request Jul 8, 2024 that will close this issue
Change the type of the error code of u32assert2 operation from Felt to u32 #1382
Merged
@Fumuran
Copy link
Contributor Author

Fumuran commented Jul 10, 2024

Closed by #1382.

@Fumuran Fumuran closed this as completed Jul 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Fumuran Fumuran

Labels
assembly Related to Miden assembly
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Change the type of the error code of u32assert2 operation from Felt to u32 0xPolygonMiden/miden-vm
1 participant
@Fumuran