Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restrict the number of stack inputs and outputs to 16 #1428

Closed
bobbinth opened this issue Aug 7, 2024 · 2 comments
Closed

Restrict the number of stack inputs and outputs to 16 #1428

bobbinth opened this issue Aug 7, 2024 · 2 comments
Assignees
Labels
air Related to Miden AIR and constraints documentation Improvements or additions to documentation processor Related to Miden VM processor
Milestone

Comments

@bobbinth
Copy link
Contributor

bobbinth commented Aug 7, 2024

Currently, we allow users to specify an arbitrary number of stack inputs and outputs. This adds quite a bit of complexity to the constraint system (i.e., needing to manage the initial and final states of the stack overflow table). Moreover, practical benefit of this capability are limited (and in some ways, may be actually detrimental).

So, I think we should remove the ability to provide an arbitrary number of stack inputs/outputs and instead limit these values to 16.

As a part of this, we should also make sure all documentation related to the stack overflow table is up to date.

@bobbinth bobbinth added processor Related to Miden VM processor air Related to Miden AIR and constraints labels Aug 7, 2024
@bobbinth bobbinth added this to the v0.11.0 milestone Aug 7, 2024
@bobbinth bobbinth added the documentation Improvements or additions to documentation label Aug 7, 2024
@Fumuran Fumuran self-assigned this Aug 13, 2024
@bobbinth
Copy link
Contributor Author

bobbinth commented Oct 3, 2024

Most of this has been addressed in #1456 - but we still need to update the documentation before we can close this issue.

@bobbinth
Copy link
Contributor Author

Closed by #1456 and #1530.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
air Related to Miden AIR and constraints documentation Improvements or additions to documentation processor Related to Miden VM processor
Projects
None yet
Development

No branches or pull requests

2 participants