Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLI bundle command: add debug_mode and kernel flags #1447

Open
plafer opened this issue Aug 12, 2024 · 1 comment
Open

CLI bundle command: add debug_mode and kernel flags #1447

plafer opened this issue Aug 12, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@plafer
Copy link
Contributor

plafer commented Aug 12, 2024

Context: #1445 (comment) and #1445 (comment)

Currently, the bundle CLI command

  1. creates a Library from a directory, and
  2. automatically includes debug symbols.

It would be great if both were configurable: a --kernel flag would create a KernelLibrary instead of a Library, and a --debug flag would specify to include debug symbols (otherwise they wouldn't be).

@bitwalker
Copy link
Contributor

I'd suggest making --debug the default, and require --debug=false or --no-debug (or something to that effect) to disable that default. Just like cargo/rustc do debug builds by default, and require specifically requesting release builds. We should probably encourage building with debug information, because without it, programs are exceedingly difficult to troubleshoot when something goes wrong in a procedure without that information.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants