Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Address must be page aligned #669

Open
recmo opened this issue Apr 7, 2020 · 0 comments
Open

Address must be page aligned #669

recmo opened this issue Apr 7, 2020 · 0 comments
Assignees
Labels
refactor Improves the code quality tracker Issues generated from source comments

Comments

@recmo
Copy link
Contributor

recmo commented Apr 7, 2020

On 2020-04-06 @recmo wrote in 1cf58de “Safe(r) madvise”:

Address must be page aligned

    fn memory_advise(&mut self, advice: Advice) {
        let length = size_of_val(self);
        if length == 0 {
            return;
        }
        // TODO: Address must be page aligned
        let address = self.as_mut_ptr() as *mut ();
        // TODO: Error handling
        advise(address, length, advice).unwrap_or_else(|_| panic!("MADVISE failed"));
    }
}

From algebra/primefield/src/fft/prefetch.rs:78

@recmo recmo added refactor Improves the code quality tracker Issues generated from source comments labels Apr 7, 2020
@recmo recmo self-assigned this Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
refactor Improves the code quality tracker Issues generated from source comments
Projects
None yet
Development

No branches or pull requests

1 participant