Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Remove this when we support negatives #695

Open
recmo opened this issue May 6, 2020 · 0 comments
Open

Remove this when we support negatives #695

recmo opened this issue May 6, 2020 · 0 comments
Assignees
Labels
refactor Improves the code quality tracker Issues generated from source comments

Comments

@recmo
Copy link
Contributor

recmo commented May 6, 2020

On 2020-05-06 @pvienhage wrote in af4b6e2 “Basic autogeneration (#687)”:

Remove this when we support negatives

    // We map each trace to the row it contains
    let mut rows = trace_keys
        .iter()
        .map(|expression| {
            match expression {
                // TODO - Remove this when we support negatives
                #[allow(clippy::cast_sign_loss)]
                RationalExpression::Trace(_, j) => *j as usize,
                _ => panic!("Non trace in trace array"),
            }
        })

From crypto/stark/src/solidity_verifier.rs:298

@recmo recmo added refactor Improves the code quality tracker Issues generated from source comments labels May 6, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
refactor Improves the code quality tracker Issues generated from source comments
Projects
None yet
Development

No branches or pull requests

2 participants