This repository has been archived by the owner on Nov 5, 2018. It is now read-only.

nftConventionId -- defend choice of bytes4 #46

Open

fulldecent opened this issue Sep 19, 2018 · 0 comments

Member

fulldecent commented Sep 19, 2018

Currently nftConventionId has a hash defined as

bytes4(keccak256(jsonSchema))

Source: https://github.com/0xcert/ethereum-xcert/blob/master/contracts/tokens/Xcert.sol#L18

The birthday attack on that is 2^16 which may be low. Is this a problem?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.