From 77c8cafa4eea47c26d2706d9850f527d3bc02c6c Mon Sep 17 00:00:00 2001
From: Xavier Carron <33637571+xav-car@users.noreply.github.com>
Date: Wed, 17 Apr 2024 15:56:32 +0200
Subject: [PATCH] remove usage of did insert / update

---
 addon/common/add-dynamic-style-tag.js         |  8 ---
 .../pix-filterable-and-searchable-select.hbs  |  1 -
 .../pix-filterable-and-searchable-select.js   | 48 ++++++++-------
 addon/components/pix-pagination.hbs           |  2 +-
 addon/components/pix-pagination.js            | 18 +++---
 addon/components/pix-select.hbs               |  2 -
 addon/components/pix-select.js                | 58 ++++++++-----------
 app/services/element-helper.js                | 32 ++++++++++
 ...x-filterable-and-searchable-select-test.js | 10 ++--
 .../integration/components/pix-select-test.js |  6 +-
 10 files changed, 99 insertions(+), 86 deletions(-)
 delete mode 100644 addon/common/add-dynamic-style-tag.js
 create mode 100644 app/services/element-helper.js

diff --git a/addon/common/add-dynamic-style-tag.js b/addon/common/add-dynamic-style-tag.js
deleted file mode 100644
index 700dc42f6..000000000
--- a/addon/common/add-dynamic-style-tag.js
+++ /dev/null
@@ -1,8 +0,0 @@
-export function createClass(name, rules) {
-  var style = document.createElement('style');
-  style.type = 'text/css';
-  document.getElementsByTagName('head')[0].appendChild(style);
-
-  if (!(style.sheet || {}).insertRule) (style.styleSheet || style.sheet).addRule(name, rules);
-  else style.sheet.insertRule(name + '{' + rules + '}', 0);
-}
diff --git a/addon/components/pix-filterable-and-searchable-select.hbs b/addon/components/pix-filterable-and-searchable-select.hbs
index b1d33cebb..c96021b42 100644
--- a/addon/components/pix-filterable-and-searchable-select.hbs
+++ b/addon/components/pix-filterable-and-searchable-select.hbs
@@ -28,7 +28,6 @@
       <:default as |option|>{{option.label}}</:default>
     </PixMultiSelect>
     <PixSelect
-      {{did-insert this.setSelectWidth}}
       @id={{this.pixSelectId}}
       @placeholder={{@placeholder}}
       @value={{@value}}
diff --git a/addon/components/pix-filterable-and-searchable-select.js b/addon/components/pix-filterable-and-searchable-select.js
index f306d30db..b68d48a43 100644
--- a/addon/components/pix-filterable-and-searchable-select.js
+++ b/addon/components/pix-filterable-and-searchable-select.js
@@ -1,14 +1,36 @@
 import Component from '@glimmer/component';
+import { inject as service } from '@ember/service';
 import { tracked } from '@glimmer/tracking';
 import { action } from '@ember/object';
 import { guidFor } from '@ember/object/internals';
-import { createClass } from '../common/add-dynamic-style-tag';
 
 export default class PixFilterableAndSearchableSelect extends Component {
+  @service elementHelper;
   @tracked selectedCategories = [];
-  mainId = 'pix-pfass-' + guidFor(this);
-  pixSelectId = 'pix-pfass-select-' + guidFor(this);
-  pixMultiSelectId = 'pix-pfass-multi-select-' + guidFor(this);
+
+  constructor(...args) {
+    super(...args);
+    this.mainId = 'pix-pfass-' + guidFor(this);
+    this.pixSelectId = 'pix-pfass-select-' + guidFor(this);
+    this.pixMultiSelectId = 'pix-pfass-multi-select-' + guidFor(this);
+
+    this.elementHelper.waitForElement(this.pixSelectId).then((element) => {
+      const baseFontRemRatio = Number(
+        getComputedStyle(document.querySelector('html')).fontSize.match(/\d+(\.\d+)?/)[0],
+      );
+
+      const multiSelectWidth = document
+        .getElementById(this.pixMultiSelectId)
+        .getBoundingClientRect().width;
+
+      const selectWidth = Math.ceil(multiSelectWidth / baseFontRemRatio);
+
+      const className = `sizing-select-${this.pixSelectId}`;
+      this.elementHelper.createClass(`.${className}`, `width: calc(100% - ${selectWidth}rem);`);
+
+      element.className = element.className + ' ' + className;
+    });
+  }
 
   @action
   selectCategories(categories) {
@@ -47,22 +69,4 @@ export default class PixFilterableAndSearchableSelect extends Component {
 
     return selectableOptions;
   }
-
-  @action
-  setSelectWidth(element) {
-    const baseFontRemRatio = Number(
-      getComputedStyle(document.querySelector('html')).fontSize.match(/\d+(\.\d+)?/)[0],
-    );
-
-    const multiSelectWidth = document
-      .getElementById(this.pixMultiSelectId)
-      .getBoundingClientRect().width;
-
-    const selectWidth = Math.ceil(multiSelectWidth / baseFontRemRatio);
-
-    const className = `sizing-select-${this.pixSelectId}`;
-    createClass(`.${className}`, `width: calc(100% - ${selectWidth}rem);`);
-
-    element.className = element.className + ' ' + className;
-  }
 }
diff --git a/addon/components/pix-pagination.hbs b/addon/components/pix-pagination.hbs
index 13283b711..7813f1788 100644
--- a/addon/components/pix-pagination.hbs
+++ b/addon/components/pix-pagination.hbs
@@ -1,4 +1,4 @@
-<footer class={{this.isCondensed}} {{did-update this.checkCurrentPageAgainstPageCount @pagination}}>
+<footer class={{this.isCondensed}}>
   <section class="pix-pagination__size">
     <span class="pagination-size__label">{{this.beforeResultsPerPage}}</span>
     <PixSelect
diff --git a/addon/components/pix-pagination.js b/addon/components/pix-pagination.js
index cdac6d9fc..5fa3db435 100644
--- a/addon/components/pix-pagination.js
+++ b/addon/components/pix-pagination.js
@@ -60,7 +60,14 @@ export default class PixPagination extends Component {
   }
 
   get currentPage() {
-    return this.args.pagination ? this.args.pagination.page : 1;
+    const currentPage = this.args.pagination ? this.args.pagination.page : 1;
+    const pageCount = this.args.pagination.pageCount;
+
+    if (currentPage > pageCount) {
+      this.router.replaceWith({ queryParams: { pageNumber: pageCount } });
+    }
+
+    return currentPage;
   }
 
   get pageCount() {
@@ -118,13 +125,4 @@ export default class PixPagination extends Component {
   goToPreviousPage() {
     this.router.replaceWith({ queryParams: { pageNumber: this.previousPage } });
   }
-
-  @action
-  checkCurrentPageAgainstPageCount() {
-    const pageCount = this.args.pagination.pageCount;
-    if (pageCount === 0) return;
-    if (this.currentPage > pageCount) {
-      this.router.replaceWith({ queryParams: { pageNumber: pageCount } });
-    }
-  }
 }
diff --git a/addon/components/pix-select.hbs b/addon/components/pix-select.hbs
index 61ed08ebc..606ab5cc3 100644
--- a/addon/components/pix-select.hbs
+++ b/addon/components/pix-select.hbs
@@ -4,7 +4,6 @@
   {{on-click-outside this.hideDropdown}}
   {{on-arrow-down-up-action this.listId this.showDropdown this.isExpanded}}
   {{on-escape-action this.hideDropdown this.selectId}}
-  {{did-insert this.setSelectWidth}}
   {{on "keydown" this.lockTab}}
   ...attributes
 >
@@ -47,7 +46,6 @@
       <div
         {{popover}}
         class="pix-select__dropdown{{unless this.isExpanded ' pix-select__dropdown--closed'}}"
-        id={{this.dropDownId}}
         {{on "transitionend" this.focus}}
       >
         {{#if @isSearchable}}
diff --git a/addon/components/pix-select.js b/addon/components/pix-select.js
index 542108cc6..5b256513a 100644
--- a/addon/components/pix-select.js
+++ b/addon/components/pix-select.js
@@ -1,30 +1,47 @@
 import Component from '@glimmer/component';
 import { tracked } from '@glimmer/tracking';
+import { inject as service } from '@ember/service';
 import { action } from '@ember/object';
 import { guidFor } from '@ember/object/internals';
-import { createClass } from '../common/add-dynamic-style-tag';
 
 export default class PixSelect extends Component {
+  @service elementHelper;
   @tracked isExpanded = false;
   @tracked searchValue = null;
-  searchId = 'search-input-' + guidFor(this);
 
   constructor(...args) {
     super(...args);
 
     const categories = [];
+
+    this.searchId = 'search-input-' + guidFor(this);
+    this.selectId = this.args.id ? this.args.id : 'select-' + guidFor(this);
+    this.listId = `listbox-${this.selectId}`;
+
     this.args.options.forEach((element) => {
       if (!categories.includes(element.category) && element.category !== undefined) {
         categories.push(element.category);
       }
     });
-
     this.displayCategory = categories.length > 0;
-  }
 
-  get selectId() {
-    if (this.args.id) return this.args.id;
-    return 'select-' + guidFor(this);
+    this.elementHelper.waitForElement(this.selectId).then((elementList) => {
+      if (!this.args.isComputeWidthDisabled) {
+        const baseFontRemRatio = Number(
+          getComputedStyle(document.querySelector('html')).fontSize.match(/\d+(\.\d+)?/)[0],
+        );
+        const checkIconWidth = 1.125 * baseFontRemRatio;
+        const listWidth = elementList.getBoundingClientRect().width;
+        const selectWidth = (listWidth + checkIconWidth) / baseFontRemRatio;
+
+        const className = `sizing-select-${this.selectId}`;
+        this.elementHelper.createClass(`.${className}`, `width: ${selectWidth}rem;`);
+
+        const element = document.getElementById(`container-${this.selectId}`);
+
+        element.className = element.className + ' ' + className;
+      }
+    });
   }
 
   get displayDefaultOption() {
@@ -51,14 +68,6 @@ export default class PixSelect extends Component {
     return this.isExpanded ? 'true' : 'false';
   }
 
-  get listId() {
-    return `listbox-${this.selectId}`;
-  }
-
-  get dropDownId() {
-    return `dropdown-${this.selectId}`;
-  }
-
   get placeholder() {
     if (!this.args.value) return this.args.placeholder;
     const option = this.args.options.find((option) => option.value === this.args.value);
@@ -155,23 +164,4 @@ export default class PixSelect extends Component {
       }
     }
   }
-
-  @action
-  setSelectWidth() {
-    if (!this.args.isComputeWidthDisabled) {
-      const baseFontRemRatio = Number(
-        getComputedStyle(document.querySelector('html')).fontSize.match(/\d+(\.\d+)?/)[0],
-      );
-      const checkIconWidth = 1.125 * baseFontRemRatio;
-      const listWidth = document.getElementById(this.listId).getBoundingClientRect().width;
-      const selectWidth = (listWidth + checkIconWidth) / baseFontRemRatio;
-
-      const className = `sizing-select-${this.selectId}`;
-      createClass(`.${className}`, `width: ${selectWidth}rem;`);
-
-      const element = document.getElementById(`container-${this.selectId}`);
-
-      element.className = element.className + ' ' + className;
-    }
-  }
 }
diff --git a/app/services/element-helper.js b/app/services/element-helper.js
new file mode 100644
index 000000000..43f98c5dc
--- /dev/null
+++ b/app/services/element-helper.js
@@ -0,0 +1,32 @@
+import Service from '@ember/service';
+
+export default class ElementService extends Service {
+  waitForElement(id) {
+    return new Promise((resolve) => {
+      if (document.getElementById(id)) {
+        return resolve(document.getElementById(id));
+      }
+
+      const observer = new MutationObserver(() => {
+        if (document.getElementById(id)) {
+          resolve(document.getElementById(id));
+          observer.disconnect();
+        }
+      });
+
+      observer.observe(document.body, {
+        childList: true,
+        subtree: true,
+      });
+    });
+  }
+
+  createClass(name, rules) {
+    var style = document.createElement('style');
+    style.type = 'text/css';
+    document.getElementsByTagName('head')[0].appendChild(style);
+
+    if (!(style.sheet || {}).insertRule) (style.styleSheet || style.sheet).addRule(name, rules);
+    else style.sheet.insertRule(name + '{' + rules + '}', 0);
+  }
+}
diff --git a/tests/integration/components/pix-filterable-and-searchable-select-test.js b/tests/integration/components/pix-filterable-and-searchable-select-test.js
index 342dd2b42..1d92163cd 100644
--- a/tests/integration/components/pix-filterable-and-searchable-select-test.js
+++ b/tests/integration/components/pix-filterable-and-searchable-select-test.js
@@ -256,7 +256,7 @@ module('Integration | Component | PixFilterableAndSearchableSelect', function (h
     const screen = await render(hbs`<PixFilterableAndSearchableSelect
   @placeholder={{this.placeholder}}
   @options={{this.options}}
-  @value={{'2'}}
+  @value='2'
   @onChange={{this.onChange}}
   @categoriesId={{this.categoriesId}}
   @categoriesPlaceholder={{this.categoriesPlaceholder}}
@@ -286,7 +286,7 @@ module('Integration | Component | PixFilterableAndSearchableSelect', function (h
       const screen = await render(hbs`<PixFilterableAndSearchableSelect
   @placeholder={{this.placeholder}}
   @options={{this.options}}
-  @value={{'2'}}
+  @value='2'
   @onChange={{this.onChange}}
   @categoriesId={{this.categoriesId}}
   @categoriesPlaceholder={{this.categoriesPlaceholder}}
@@ -314,7 +314,7 @@ module('Integration | Component | PixFilterableAndSearchableSelect', function (h
   @subLabel={{this.subLabel}}
   @placeholder={{this.placeholder}}
   @options={{this.options}}
-  @value={{'2'}}
+  @value='2'
   @onChange={{this.onChange}}
   @categoriesId={{this.categoriesId}}
   @categoriesPlaceholder={{this.categoriesPlaceholder}}
@@ -339,7 +339,7 @@ module('Integration | Component | PixFilterableAndSearchableSelect', function (h
       const screen = await render(hbs`<PixFilterableAndSearchableSelect
   @placeholder={{this.placeholder}}
   @options={{this.options}}
-  @value={{'2'}}
+  @value='2'
   @onChange={{this.onChange}}
   @categoriesId={{this.categoriesId}}
   @categoriesPlaceholder={{this.categoriesPlaceholder}}
@@ -369,7 +369,7 @@ module('Integration | Component | PixFilterableAndSearchableSelect', function (h
     const screen = await render(hbs`<PixFilterableAndSearchableSelect
   @placeholder={{this.placeholder}}
   @options={{this.options}}
-  @value={{'2'}}
+  @value='2'
   @onChange={{this.onChange}}
   @categoriesId={{this.categoriesId}}
   @categoriesPlaceholder={{this.categoriesPlaceholder}}
diff --git a/tests/integration/components/pix-select-test.js b/tests/integration/components/pix-select-test.js
index f3fe35e7d..967ec3a61 100644
--- a/tests/integration/components/pix-select-test.js
+++ b/tests/integration/components/pix-select-test.js
@@ -144,7 +144,7 @@ module('Integration | Component | PixSelect', function (hooks) {
       test('it should display list, focus selected element on arrow up press', async function (assert) {
         // given
         const screen =
-          await render(hbs`<PixSelect @options={{this.options}} @value={{'3'}} @placeholder={{this.placeholder}}><:label
+          await render(hbs`<PixSelect @options={{this.options}} @value='3' @placeholder={{this.placeholder}}><:label
   >{{this.label}}</:label></PixSelect>`);
 
         // when
@@ -164,7 +164,7 @@ module('Integration | Component | PixSelect', function (hooks) {
       test('it should display list, focus selected element on arrow down press', async function (assert) {
         // given
         const screen =
-          await render(hbs`<PixSelect @options={{this.options}} @value={{'2'}} @placeholder={{this.placeholder}}><:label
+          await render(hbs`<PixSelect @options={{this.options}} @value='2' @placeholder={{this.placeholder}}><:label
   >{{this.label}}</:label></PixSelect>`);
 
         // when
@@ -184,7 +184,7 @@ module('Integration | Component | PixSelect', function (hooks) {
       test('it should display list, focus selected element on space press', async function (assert) {
         // given
         const screen =
-          await render(hbs`<PixSelect @options={{this.options}} @value={{'1'}} @placeholder={{this.placeholder}}><:label
+          await render(hbs`<PixSelect @options={{this.options}} @value='1' @placeholder={{this.placeholder}}><:label
   >{{this.label}}</:label></PixSelect>`);
 
         // when