Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handling of shortlinks #88

Closed
jeffpaul opened this issue Mar 10, 2020 · 2 comments · Fixed by #288
Closed

Handling of shortlinks #88

jeffpaul opened this issue Mar 10, 2020 · 2 comments · Fixed by #288
Assignees
Labels
needs:ux This requires user experience to resolve. type:bug Something isn't working.
Milestone

Comments

@jeffpaul
Copy link
Member

Describe the bug
Originally reported by @rickalee: #57 (comment)

Client just had a permalink with 165 characters that truncated post title. I see the 'autoshare_for_twitter_post_url' filter but I think we should add a Setting to use shortlinks i.e. example.com/?p=1234

Original response by @jeffpaul: #57 (comment)

@rickalee using shortlinks, as an option, seems to make sense. Though I'm surprised that Twitter itself didn't shorten the link with their t.co link shortener, I wonder if there's a way to trigger that via their API so we don't need to worry about adding a setting for that in the plugin and just let Twitter shorten things on their end?

Sidebar: let's move this into a separate issue to discuss link shortening.

Steps to Reproduce

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior

If a link to the post/page/whatever is included in our tweet status, then my assumption is those links (if they're longer than the t.co links) will be shortened to the t.co link when posted to Twitter.

Screenshots

n/a

Environment information

  • Device:
  • OS:
  • Browser and version:
  • WordPress version:
  • Plugins and version:
  • Theme and version:
  • Site Health Info:

Additional context

Related to #57

@jeffpaul jeffpaul added type:bug Something isn't working. needs:ux This requires user experience to resolve. labels Mar 10, 2020
@jeffpaul jeffpaul added this to the Future Release milestone Mar 10, 2020
@jeffpaul
Copy link
Member Author

@rickalee let's pick up conversation on your shortlink bug/needs here; please provide a little more clarity on the issue you're seeing as my assumption is that t.co links should resolve any issues with links truncating status messages when posted to Twitter.

@iamdharmesh
Copy link
Member

This could be fixed by #288

@jeffpaul jeffpaul linked a pull request Oct 23, 2023 that will close this issue
13 tasks
@jeffpaul jeffpaul moved this from Incoming to Review Approved in Open Source Practice Oct 23, 2023
@jeffpaul jeffpaul modified the milestones: Future Release, 2.2.0 Oct 23, 2023
@github-project-automation github-project-automation bot moved this from Review Approved to Merged in Open Source Practice Oct 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs:ux This requires user experience to resolve. type:bug Something isn't working.
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants