-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ssh-rs panic on a thread when using in multi threading #77
Comments
Hi, May I have a copy of your PoC code? It looks strange cuz this assert is only to test the first 4 bytes of the ssh server replies when we connected. A fatal here is that we shall throw an error rather than panic. But if you're connecting a true ssh server, it is worth investigating more about how could it happen. BRs. |
Hi, thank you for your help. PoC
|
Hi @Paulo-21 With #78 it now returns an error It's actually some error message which indicates that the server is not able to handle more clients.
I'll later have 0.4.2 released to include the fix. Thank you for reporting! BRs. |
Hi @HsuJv |
Hello,
I had an issue with your library.
One thread panic when i use more threads than i have physical cores.
When i use Available parallelism from the rust standard library, i got 12 cores.
I precise that my cpu have 8 cores without hyper threading and 2 physical cores with Hyper Threading.
So 10 physical core without hyper threading.
When i set the number of threads to 10, no crash happen but when i increase the number of threads to 11 or 12 then it crash.
i m just running n threads and running ssh inside of each one.
The text was updated successfully, but these errors were encountered: