Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Call to RFC6979 needs another argument added #410

Open
ellacodecamp opened this issue Jul 22, 2024 · 0 comments
Open

Call to RFC6979 needs another argument added #410

ellacodecamp opened this issue Jul 22, 2024 · 0 comments

Comments

@ellacodecamp
Copy link

When you call RFC6979() function in USE_FASTECDSA case, you need to pass it additional argument True for prehashed parameter. This means that the message that you pass it to generate k does not need to be hashed again. Indeed, this value has already been double hashed in by Transaction object. There is no need to hash it again. While there is no harm in hashing it again, it makes you inconsistent with other wallets as you won't have the same signature for the same transaction, which was the whole point for actually generating deterministic signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant