Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create 2023-10-28-Astrid-Finance.md #382

Merged
merged 6 commits into from
Apr 9, 2024

Conversation

svg-arch
Copy link
Contributor

@svg-arch svg-arch commented Mar 2, 2024

No description provided.

@svg-arch svg-arch requested a review from a team as a code owner March 2, 2024 12:27
@JediFaust
Copy link
Contributor

/articlecheck

1 similar comment
@JediFaust
Copy link
Contributor

/articlecheck

Copy link

github-actions bot commented Mar 5, 2024

Fact Checking

Editor's Notes

In the ## Timeline section:

  • The date format is inconsistent. It should follow the 'Month day, year, time PM UTC:' format for all entries.

  • The word 'Finane' is misspelled and should be 'Finance'.

  • The timeline entry on October 28, 2023 at 02:51:35 PM UTC regarding the bounty offer to the hacker is missing. This should be added for completeness.

Hugo SSG Formatting Check

  • Does it match Hugo SSG formatting? ✅

Filename Check

  • Correct Filename: 2023-10-28-Astrid-Finance.md
  • Your Filename: 2023-10-28-Astrid-Finance.md

Section Headers Check

  • Allowed Headers: ## Summary, ## Attackers, ## Losses, ## Timeline, ## Security Failure Causes
  • Your Headers: ## Summary, ## Attackers, ## Losses, ## Timeline, ## Security Failure Causes

Metadata Headers Check

  • Allowed Metadata Headers: date, target-entities, entity-types, attack-types, title, loss

  • Your Metadata Headers: date, target-entities, entity-types, attack-types, title, loss

  • Notes:

    • The date metadata matches the date October 28, 2023 mentioned in the Summary ✅
    • The target-entities metadata matches Astrid Finance mentioned in the Summary ✅
    • The loss metadata matches the ~$228,000 loss mentioned in the Losses section ✅
    • The entity-types of DeFi matches the target entity Astrid Finance ✅
    • The attack-types of Smart Contract Exploit matches the type of attack described ✅

@evgenydmitriev
Copy link
Contributor

/articlecheck

Copy link

github-actions bot commented Apr 9, 2024

Fact-Checking Results

Editor's Notes

  • In the Timeline section:

    • Standardize the date-time format to 'Month Day, Year, Time PM UTC'
    • Add a colon after 'PM'
    • Change 10:41 AM UTC to 10:41 AM UTC
    • Change 02:13 PM UTC to 02:13 PM UTC
    • Change 02:51 PM UTC to 02:51 PM UTC
    • Change 07:22 PM UTC to 07:22 PM UTC
  • Change 'Finane' to 'Finance'

  • Standardize capitalization of 'stETH', 'rETH', 'cbETH'

Hugo SSG Formatting Check

  • Does it match Hugo SSG formatting? ✅

Filename Check

  • Correct Filename: 2023-10-28-Astrid-Finance.md
  • Your Filename: 2023-10-28-Astrid-Finance.md

Section Headers Check

  • Allowed Headers: ## Summary, ## Attackers, ## Losses, ## Timeline, ## Security Failure Causes
  • Your Headers: ## Summary, ## Attackers, ## Losses, ## Timeline, ## Security Failure Causes

Metadata Headers Check

  • Allowed Metadata Headers: date, target-entities, entity-types, attack-types, title, loss

  • Your Metadata Headers: date, target-entities, entity-types, attack-types, title, loss

  • Notes:

    • Date in text: October 28, 2023

    • Date in metadata: 2023-10-28 ✅

    • Target entity in text: Astrid Finance

    • Target entities in metadata: Astrid Finance ✅

    • Loss in text: $228,000

    • Loss in metadata: 228000 ✅

@evgenydmitriev evgenydmitriev merged commit 5d48d1c into 1712n:main Apr 9, 2024
1 check passed
@evgenydmitriev
Copy link
Contributor

/payout

Copy link

github-actions bot commented Apr 9, 2024

Thanks, @svg-arch! 2532 characters were added/changed in this PR. At a rate of 3¢/char multiplied by 1x your contribution is worth $75.96. @albina-at-inca will process your payment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants