Feature/article checker workers with queue #447
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Why do you need to maintain your connection with GitHub? The webhook is only needed to trigger the worker. What you do after (and for how long) is none of GitHub's business. Get whatever you need from GitHub, drop the connection, do your thing, and establish a new connection to post the PR comment whenever you are ready. |
Kseymur
changed the title
|
@evgenydmitriev Rewrote it into a system with two workers and a queue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request resolves #425.
When attempting to create a worker that responds to GitHub webhooks and starts processing the diff, I encountered the following limitations:
GitHub expects a response to the webhook within 10 seconds. This caused the worker to crash as it couldn't complete the processing in time.
Using waitUntil, which could send a response to GitHub immediately and continue processing in the background, is also not feasible in our case due to time constraints. Waiting for a response from OpenAI might take longer.
Considering these limitations, I decided to use a worker with Durable Objects and Alarms. This allows the worker to respond to GitHub immediately and then proceed with processing the diff in the background.
Improvements that can be made: