Accessibility issue with Work with us links

[brentryanjohnson]

Expected Behavior

• Identical accessible names have identical href values

Actual Behavior

• Identical accessible names have different href values

Proposed fixes

• Pass a more descriptive accessible name that contains the visual text, in accordance with WCAG 2.2
• Employ unique text for unique href values

Screenshot of error

The error was detected with GSA's AMP tool

[dluetger]

Do we know what the second link was with the same name? The "work with us" in the footer? If so, the only difference seems to be the menu one is implemented as a <span>, but they both go to the same place which is a shortcut back to this page.

Working on getting AMP access so I can replicate. WAVE doesn't see it, but will try some other tools

[dluetger]

Okay, I think I see it. The one in the homepage subsection "What 18F can do" goes to "how we work" and not "work with us." Is it intentional the call to action here has the same text? I would have guesses the button said "How we work" to match it's destination. I'm thinking I'll make a PR for that change unless there are objections

[dluetger]

Oh, "how we work" isn't even a page and redirects to "work with us" lol. So, yeah, I think the fix is on the homepage to make that third link match the rest as intended then :P

[dluetger]

Got AMP access and was able to replicate. Annoyingly AMP does not show which links don't match and just throws all of them at you. Anyway, the preview page from the PR seems to pass