Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

replatform: redirect from team to author is not implemented #4043

Closed
Tracked by #3967
cantsin opened this issue Aug 6, 2024 · 5 comments
Closed
Tracked by #3967

replatform: redirect from team to author is not implemented #4043

cantsin opened this issue Aug 6, 2024 · 5 comments
Labels

Comments

@cantsin
Copy link
Contributor

cantsin commented Aug 6, 2024

Example:

https://18f.gsa.gov/team/tadhg/ goes to https://18f.gsa.gov/author/tadhg/

We have no such redirect for the replatformed effort; I think we missed this directory-level redirect.

Note: other per-page redirections work. /project/eregulations/ goes to /our-work/eregulations/, for instance.

@beechnut
Copy link
Contributor

beechnut commented Aug 6, 2024

Okay so — the redirects are specified at the individual author level in the file inside _data/. I don't have the whole solution in mind, but my first step is to look into adding redirect metadata to the 11ty data file that turns _data/authors into pages.

@beechnut
Copy link
Contributor

beechnut commented Aug 6, 2024

There's a tricky indirection here: the redirects are all handled by content/redirect.html.

I tried adding

# content/pages/author.liquid
redirect_from: "{{ author.redirect_from }}"

but this creates a folder _site/{{ author.redirect_from }}, which is not what we want.

And this seems to do nothing at all:

# content/pages/author.liquid
eleventyComputed:
  redirect_from: "{{ author.redirect_from }}"

There's a _site/team/18F/index.html but it could be coming from somewhere other than the author data.

@beechnut
Copy link
Contributor

beechnut commented Aug 6, 2024

Okay, a challenge question: does this matter enough to be part of the migration? I think we've been redirecting from /team urls for years, to the point that I'd be surprised if anyone is still pinging those.

Do we have analytics with which to test the hypothesis? Can we see if anyone's touched /team/* in the last 3 years?

@cantsin
Copy link
Contributor Author

cantsin commented Aug 7, 2024

So, the thing is that GA does not track redirects, or at least it won't tell us where the redirect came from (afaics). So we may have no real way of knowing.

I looked at the top 500 visited paths for the last year (the limit is 500) and author appears quite a few times.

I tried being more explicit:

20240807_06h25m10s_grim
gives us no matches whatsoever.

I'm comfortable punting on this one until we find concrete evidence otherwise.

@beechnut
Copy link
Contributor

beechnut commented Aug 8, 2024

Closing for now to unblock site release

@beechnut beechnut closed this as completed Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants