Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove CircleCI #4080

Closed
caleywoods opened this issue Aug 21, 2024 · 3 comments · Fixed by #4081
Closed

Remove CircleCI #4080

caleywoods opened this issue Aug 21, 2024 · 3 comments · Fixed by #4081

Comments

@caleywoods
Copy link
Contributor

caleywoods commented Aug 21, 2024

Feature suggestion

The 18F website was recently migrated from Jekyll to 11ty and with that we're now using GitHub actions to validate HTML, check links, and do linting on pull requests instead of CircleCI. I'm proposing that we should remove CircleCI.

I wanted to open this issue for discussion before I just go deleting things.

Work required

From what I can tell, the work is:

Who is going to do this work?

I'm happy to take this on, it seems like a quick thing to do.

References

@caleywoods
Copy link
Contributor Author

@beechnut @cantsin Tagging you two for visibility of this since. I wasn't sure who else may have context, please add them to the discussion.

@cantsin
Copy link
Contributor

cantsin commented Aug 22, 2024

I think this makes a lot of sense. Let's just do it. I don't think this needs a lot of discussion -- I don't think anyone else will complain, as long as tests run somewhere and the test results are shown in pull requests/merges/etc.

@caleywoods
Copy link
Contributor Author

I think this makes a lot of sense. Let's just do it. I don't think this needs a lot of discussion -- I don't think anyone else will complain, as long as tests run somewhere and the test results are shown in pull requests/merges/etc.

I agree, I was just hoping not to pull the rug out from under someone in case I had overlooked something still being done on CircleCI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants