Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Plugin lags with larger config files #12

Open
riesegarder opened this issue Jul 2, 2024 · 5 comments
Open

Plugin lags with larger config files #12

riesegarder opened this issue Jul 2, 2024 · 5 comments
Labels
enhancement New feature or request plugin Related to the Roblox Studio plugin

Comments

@riesegarder
Copy link

Lag spikes occur mostly when adding/removing new lines, and also when autocomplete is triggered
https://jmp.sh/lgfvAHF9

For reference, the config I'm editing is 191 lines with 4,350 characters in total

I've been noticing the lag gradually, it's just that I ignored them and assumed it's my potato laptop, but it's gotten to this point where I actually make changes on Notepad instead and only use the plugin to generate the network modules..

If there's a way to disable the autocomplete (or whatever was causing the lag), I'd be fine with just having the editor even without the colors

@1Axen 1Axen added the enhancement New feature or request label Jul 2, 2024
@1Axen
Copy link
Owner

1Axen commented Jul 2, 2024

The Studio Plugin would benefit from some refactoring in a lot areas, I've got a few ideas to better optimise the plugin. As for the time being I will look into adding the ability to disable some editor features to help with the lag.

@1Axen
Copy link
Owner

1Axen commented Jul 6, 2024

I've just merged #13 and released v0.13.5 containing some performance improvements to the plugin, it's nothing major but it should help with the performance issues. Give it a try and let me know how it goes!

I will be keeping the issue open as I have more changes in mind and I am not yet satisfied with the performance of the studio plugin, said changes are more than a weekends worth of work though as they require refactoring of the parser.

@riesegarder
Copy link
Author

Just checked it out -- unfortunately still the same for me 😓 just tried it using the same files I got and get the same performance issues as before.

@riesegarder
Copy link
Author

I wanna update a bit: I've got a PC now with much better perf than the laptop I used to work on, but the plugin lag is still the same :( was half expecting it'd be better here but somehow there's barely any difference

@1Axen
Copy link
Owner

1Axen commented Jul 20, 2024

I'm currently working on a complete rewrite of blink which will massively improve the performance of the editor, for reference the new lexer is 2.4x faster on the same file (2.35ms to 974 microseconds). Unfortunately this means that outside of major bug fixes I'm not maintaining the current version.

@1Axen 1Axen added the plugin Related to the Roblox Studio plugin label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request plugin Related to the Roblox Studio plugin
Projects
None yet
Development

No branches or pull requests

2 participants