Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check formatting in CI/CD pipeline #84

Open
Marton6 opened this issue Nov 25, 2024 · 0 comments
Open

Check formatting in CI/CD pipeline #84

Marton6 opened this issue Nov 25, 2024 · 0 comments

Comments

@Marton6
Copy link
Member

Marton6 commented Nov 25, 2024

Overview

Currently we have pre-commit and pre-push hooks that detect formatting errors in all files checked into the repo.

One problem is that, if you don't have husky installed and set up these commit hooks won't run and formatting errors may slip into the codebase.

To prevent these errors from reaching the main branch, we should also run npm run validate in CI.

Expected outcome

All formatting errors in js code, config files, scripts and markdown files should be detected by our CI pipeline before merging to main.

Context

While reviewing this MR submitted to this repository by a contributor who had set up husky, we noticed that husky automatically fixed some formatting errors it detected in unrelated files (CONTRIBUTING.MD). This signaled to us that formatting errors have accidentally been merged to main previously.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant