Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default period is too fast for some ISPs #83

Open
bandtank opened this issue May 17, 2020 · 4 comments
Open

Default period is too fast for some ISPs #83

bandtank opened this issue May 17, 2020 · 4 comments
Labels

Comments

@bandtank
Copy link

I installed vaping and tried to run it using the standalone_dns example, but no results were returned by fping. Having never used either tool, I assumed vaping was the issue because sending a ping is such a benign command that I figured it must have been working. After coming across #22, I decided to check fping and, lo and behold, it was not working. My ISP does not allow ping requests with a 20 ms period and I confirmed that by configuring multiple groups of targets in my config file. Everything inside my LAN worked fine, but anything to the WAN was non-responsive. I changed the period to be 200 ms and it worked as expected.

I think setting the period to 20 ms without really mentioning it could be causing problems for other people as well. It either needs more attention drawn to it in the documentation or a higher default value to make it more compatible with various ISPs.

@marconett
Copy link

It's not just ISPs, some firewalls also protect against this amount of echo requests. See: http://dennisk.freeshell.org/cis240dl_ping_flood.mkd.html

+1 to up the default to something less spammy.

@grizz grizz added the v2.0 label May 27, 2021
@ghost
Copy link

ghost commented Mar 3, 2023

@bandtank hello, how did you change the period? (sorry for the mention!)
I was so confused why "fping -u -C10 -p20 -e 8.8.8.8 4.2.2.1 208.67.222.222" results only dashes
I thought there was a problem with my armbian, but then I changed "-p20" to "-p200" it worked!!

which config/file do I edit to change the period? I can change the count and interval from this guide https://vaping.readthedocs.io/en/latest/quickstart/ but no mention about period

sorry for hijacking an old thread

EDIT: AHH, NVM!!! I found it!!
I was testing the "standalone_dns" example, all I had to do was to add "period: 200" in the config.yml file!!
"YourFolder/vaping/examples/standalone_dns/config.yml" for my case

  - name: std_fping
    type: fping
    count: 10
    interval: 3s
    period: 200 << added this!
    output:
      - vodka

sorry if this was so obvious

@grizz
Copy link
Member

grizz commented Mar 3, 2023

All good, thanks! I think it's time to change the default as well, I've ran into that a few times too.

aerickson added a commit to aerickson/vaping that referenced this issue Nov 28, 2023
github-merge-queue bot pushed a commit that referenced this issue Nov 28, 2023
@bitclick
Copy link

bitclick commented Aug 15, 2024

merge #179 has no effect. the is an invisible special char that blocks vaping from reading the setting.

see 9f47d2e#commitcomment-145406618

this affects current release version
commit 8ebc19260540d442d7c1d85f66f301e361bc9f81 (HEAD -> main, tag: 1.5.4, origin/main, origin/HEAD)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants