Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Block commit when changes aren't staged #12

Open
xipasduarte opened this issue Feb 15, 2023 · 0 comments
Open

Block commit when changes aren't staged #12

xipasduarte opened this issue Feb 15, 2023 · 0 comments
Assignees
Labels
enhancement New feature or request

Comments

@xipasduarte
Copy link
Member

Is your feature request related to a problem? Please describe.
After starting a commit, which triggers the linting process, we get changed files (if any fall out of the PHPCS specs). After this, if we want, we can commit again and the process doesn't identify that the files are staged, which generates a commit without clean code.

Describe the solution you'd like
The package should block any commits while the staged files have issues. This means we should lint the files that are about to be committed and leave the other alone.
To allow users the chance to skip the linting step we should rely on a flag when committing.

@xipasduarte xipasduarte added the enhancement New feature or request label Feb 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants