New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reimplement so-called "tree tuple" settings #1

Open

gnarea opened this issue Mar 19, 2013 · 1 comment

Labels

Milestone

Contributor

gnarea commented Mar 19, 2013

There are a number of issues with the implementation:

The name isn't self-explanatory.
The data structure is only useful for the TEMPLATE_LOADERS settings (sometimes) but the implementation does more than it should:
- It makes it possible to define custom "tree tuples".
- It supports unlimited nesting of "tree tuples".
- It supports the case when items in the tuple end with a comma by ignoring it.
It's undocumented.

I think this functionality should be kept simple by removing the unnecessary features and restricting it to the TEMPLATE_LOADERS setting.

Contributor Author

gnarea commented Oct 23, 2014

This applied to the original implementation of setting value parsing, before the switch to JSON.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment