Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix readability issue with CodeMirror on dark mode #249

Open
adam-buckley opened this issue Feb 2, 2024 · 0 comments
Open

Fix readability issue with CodeMirror on dark mode #249

adam-buckley opened this issue Feb 2, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@adam-buckley
Copy link
Contributor

adam-buckley commented Feb 2, 2024

In light mode the CodeMirror editor looks fine:
image

But in dark mode it's not great:
image

The sidebar is not in dark mode and the constrast of the red colouring makes it very hard to read.

Since dark mode support is kind of there from codemirror, we should be making a CodeMirror.scss file in the new designs and adding our theming overrides there

@adam-buckley adam-buckley self-assigned this Feb 2, 2024
@chris-bateman chris-bateman self-assigned this Feb 5, 2024
@chris-bateman chris-bateman added the bug Something isn't working label Feb 5, 2024
@chris-bateman chris-bateman removed their assignment Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants