Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: TinyMCE WYSIWYG Editor reports content changed even if it didn't (Confirmation Dialog only if dirty) #890

Closed
SCullman opened this issue Jul 22, 2016 · 6 comments
Closed

Fix: TinyMCE WYSIWYG Editor reports content changed even if it didn't (Confirmation Dialog only if dirty) #890

SCullman opened this issue Jul 22, 2016 · 6 comments
Assignees
@christophbuehler
Labels
done wait4ng8ui Wait for Angular 8 UI waiting-for-input
Milestone
2sxc 09.0x Quick...

Comments

@SCullman
Copy link
Contributor

If a form is closed without saving, a confirmation dialog appears.
This drives one of my power users nuts. She asks whether it would be possible to track for changes, and that the dialog only appears if the data is dirty.
@iJungleboy
Copy link
Contributor

It actually does a dirty-check, but something isn't perfect with the tiny-mce wysiwyg integration, which reports dirty even if not manually changed. So I'm guessing that this is the real problem. Could you test / verify and then maybe change the issue to fix-dirty-checking on tiny-mce?

@raphael-m
Copy link
Contributor

Had a look at it - the angular-ui-tinymce directive always reports a dirty value: angular-ui/ui-tinymce#238. The issue has been closed, but it doesn't seem to work as expected.

@iJungleboy
Copy link
Contributor

Let's wait & see what angular-ui says. We'll postpone this for a few days...

@iJungleboy iJungleboy changed the title Confirmation Dialog only if dirty Fix: TinyMCE WYSIWYG Editor reports content changed even if it didn't (Confirmation Dialog only if dirty) Dec 3, 2016
@iJungleboy
Copy link
Contributor

Posted a new issue angular-ui/ui-tinymce#315

@iJungleboy iJungleboy added this to the 2sxc 8.12 Some new features milestone Mar 29, 2017
@christophbuehler
Copy link
Member

christophbuehler commented Apr 4, 2017 •
edited
Loading

'ui-tinymce' has to be updated!
angular-ui/ui-tinymce#315 (comment)

I have not succeeded in overwriting this behavior from outside of 'ui-tinymce', so we'll have to wait for an answer.

@iJungleboy iJungleboy reopened this Apr 18, 2017
@iJungleboy iJungleboy modified the milestones: 2sxc 8.12.01 Bugfixing, 2sxc 09.00.02 Quick fixes second week, 2sxc 09.00.02 Quick fixes, 2sxc 09.00.03 Quick fixes May 6, 2017
@iJungleboy iJungleboy added the wait4ng8ui Wait for Angular 8 UI label Jun 9, 2018
@iJungleboy
Copy link
Contributor

I'm not sure if this is still an issue, so I'll close for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@christophbuehler christophbuehler

Labels
done wait4ng8ui Wait for Angular 8 UI waiting-for-input
Projects
None yet
Milestone
2sxc 09.0x Quick fixes Queue
Development

No branches or pull requests
4 participants
@christophbuehler @raphael-m @iJungleboy @SCullman