Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(updateGoal): Enable update goal name and/or category after set #29

Merged
merged 2 commits into from
Nov 8, 2024

Conversation

marycaserio
Copy link
Contributor

@marycaserio marycaserio commented Nov 8, 2024

  • Added edit goal functionality: Integrated an Edit Goal mode within the GoalDetails page, allowing users to update the goal name and category color directly from the goal header.

  • UI adjustments:

    • Added a dedicated Edit button to toggle the edit mode for the goal.
    • Added hover color changes using darken for the Edit button, providing visual feedback and aligning with the goal's theme color.
    • Used presetValue and presetCategory props in the AddItem component to prefill goal details during editing.
  • Code structure improvements:

    • Add the updateGoal function to update specific goal name and/or category.
    • Used Collapse to smoothly show/hide the Edit Goal input field on toggle.

Copy link

github-actions bot commented Nov 8, 2024

🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-29-fhs7u4b3.web.app

🧪 Test Results

Tests Passed: All tests passed successfully!


🎨 Prettier Format Check

Prettier: No formatting issues found!

🎨 Lint Check

Lint: No linting issues found!

Copy link

github-actions bot commented Nov 8, 2024

🚀 Preview for this PR is available at: https://stepwise-bdab7--pr-29-fhs7u4b3.web.app

🧪 Test Results

Tests Passed: All tests passed successfully!


🎨 Prettier Format Check

Prettier: No formatting issues found!

🎨 Lint Check

Lint: No linting issues found!

@ZL-Asica ZL-Asica changed the title feat(Category): enable editing goal category feat(updateGoal): Enable update goal name and/or category after set Nov 8, 2024
@ZL-Asica
Copy link
Member

ZL-Asica commented Nov 8, 2024

demo

@ZL-Asica ZL-Asica enabled auto-merge (squash) November 8, 2024 06:56
@ZL-Asica ZL-Asica disabled auto-merge November 8, 2024 06:56
@ZL-Asica ZL-Asica merged commit 757341a into main Nov 8, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants