Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small bug(?) in exporting COLMAP database #90

Open
oUp2Uo opened this issue Jan 10, 2025 · 4 comments
Open

small bug(?) in exporting COLMAP database #90

oUp2Uo opened this issue Jan 10, 2025 · 4 comments

Comments

@oUp2Uo
Copy link

oUp2Uo commented Jan 10, 2025

Hi, recently I am trying SFM disambiguation which will need to edit COLMAP database, and I find that the exported COLMAP database has different columns when using different images.
Sometimes qvec and tvec is exited (this is normal situation).
But occasionally, there are no these two columns, while running the same commands but using different images.
Although these values are all null, but some other programs will read these columns when loading COLMAP database.
I try to add qvec and tvec manually and it works.

qvec_tvec

no_qvec_tvec

I have tried to check the source code, but still could not understand why qvec and tvec columns are gone.
Maybe is the difference between calling add_matches and add_raw_matches?
https://github.com/3DOM-FBK/deep-image-matching/blob/master/src/deep_image_matching/io/h5_to_db.py

Thank you.

@lcmrl
Copy link
Collaborator

lcmrl commented Feb 6, 2025

Hi, thanks for reporting and sorry for the late reply. Did you find the source of the issue?
The databases you are showing are generated both from DIM or one of them is just from COLMAP?

@oUp2Uo
Copy link
Author

oUp2Uo commented Feb 7, 2025

Hi @lcmrl ,

Thanks for the reply.
As I said in the last post, the databases were all generated by DIM (using different images), but some result would have qvec and tvec, and some would not.
I am not sure about the reason.
Maybe is the difference between calling add_matches and add_raw_matches.

I just check the database manually using sqlitestudio, and add these columns if there are no qvec and tvec.

@lcmrl
Copy link
Collaborator

lcmrl commented Feb 10, 2025

Ok thanks, I am trying to reproduce the problem and to solve it. This bug should not affect the performance, but I keep the issue open if someone else encounter problems on that

@oUp2Uo
Copy link
Author

oUp2Uo commented Feb 11, 2025

Hi @lcmrl ,
Yes, that is why I wrote 'small bug' in the title.
: )

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants