Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

save / load - support 2d layer node #295

Closed
kfarr opened this issue Jun 10, 2023 · 3 comments
Closed

save / load - support 2d layer node #295

kfarr opened this issue Jun 10, 2023 · 3 comments
Assignees

Comments

@kfarr
Copy link
Collaborator

kfarr commented Jun 10, 2023

in many cases this node is not used

here is an example of it being used
https://github.3dstreet.org/mapbox.html

in this example, the mapbox satellite street layer should be saved under 2d layer node

@kfarr kfarr converted this from a draft issue Jun 10, 2023
@Algorush
Copy link
Collaborator

Algorush commented Jul 29, 2023

In order for the scene loading with the mapbox component to work, I added component code (aframe-mapbox-component.min.js) to the src/lib folder and changed THREE.Math to THREE.MathUtils, since THREE.Math is not supported in new versions of three.js. Should I create separate PR for this or no?

@Algorush
Copy link
Collaborator

Algorush commented Jul 29, 2023

I also found that the scene does not save with all the cars on one of the streets at the intersection. After fixing this issue, I will upload a PR. I think that its related with this issue: #306

@kfarr kfarr moved this from To Do to In progress in 3DStreet Dev Tracking Aug 3, 2023
@kfarr kfarr moved this from In progress to For Review in 3DStreet Dev Tracking Aug 3, 2023
@kfarr
Copy link
Collaborator Author

kfarr commented Aug 3, 2023

closed with 3DStreet/3dstreet-editor#223

@kfarr kfarr closed this as completed Aug 3, 2023
@github-project-automation github-project-automation bot moved this from For Review to Done in 3DStreet Dev Tracking Aug 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants