-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add title UI element to viewer #336
Comments
So I can place the title update in the |
#359 |
@Algorush this looks really good! Some feedback:
|
some more resources on event stuff:
|
added commit with scene-title component and event emitter from metadata component |
excellent for v1! |
closed with #359 |
From the 3dstreet viewer -- as a scene viewer, if the scene has a name, the scene name should be visible. the scene name should be accessible to viewer UI (also aframe scene) from all methods of loading scenes: 3dstreet json, streetmix, 3dstreet cloud
This should use: #335 such as:
AFRAME.scenes[0].getAttribute('metadata').sceneTitle
This UI element should update if the component property value changes (it may be set by means of editor or a loader)
Figma:
https://www.figma.com/file/W9jid3A0jgssnIKBFEvG38/3DStreet-2022?type=design&node-id=5482-23977&mode=design&t=0PBswixNj1m6p5ZK-4
Pasted png for convenience:
The title should not be clickable, and clicks on the title should instead go to the 3d canvas as though the name wasn't there
brainstorming ways to solve this:
The text was updated successfully, but these errors were encountered: