Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Record canvas in posthog #691

Open
rahulkgupta opened this issue Jul 3, 2024 · 9 comments
Open

Record canvas in posthog #691

rahulkgupta opened this issue Jul 3, 2024 · 9 comments

Comments

@rahulkgupta
Copy link
Collaborator

Context: https://posthog.com/questions/canvas-recording-not-working

From Vincent: You would need a custom aframe build to test that. preserveDrawingBuffer is an option for WebGLRenderer, you can add it here https://github.com/aframevr/aframe/blob/ca7b02ddd7bfa9d606cbbe7b092eb0c08afe5728/src/core/scene/a-scene.js#L618

@kfarr
Copy link
Collaborator

kfarr commented Jul 3, 2024

  • download aframe 1.5 tag
  • modify the build under context preserve drawing buffer (see Vincent's link above)
  • build it and try it?

will monkeypatch like raytracing work?

  • no, that was just for the render function, not the creation of the webgl renderer

@vincentfretin
Copy link
Collaborator

If that works, add a preserveDrawingBuffer property to aframe renderer attribute and create a PR upstream aframevr/aframe#3750

@rahulkgupta
Copy link
Collaborator Author

  • download aframe 1.5 tag
  • modify the build under context preserve drawing buffer (see Vincent's link above)
  • build it and try it?

will monkeypatch like raytracing work?

  • no, that was just for the render function, not the creation of the webgl renderer

should we do this by forking a-frame repo? I'm eager to get this fixed

@vincentfretin
Copy link
Collaborator

Yes fork it, create a branch, make a quick change, create a build and copy it locally to 3dstreet repo and reference it in index.html
If that works, make a PR to a aframe with a better change adding an option to the renderer so that we don't leave forever with a fork.

@rahulkgupta
Copy link
Collaborator Author

hmm i dont think it worked. Tried it in https://github.com/rahulkgupta/aframe/tree/preservedrawingbuffer

  1. updated src/core/scene/a-scene.js
  2. ran npm build dist
  3. copied aframe-master.min.js to 3dstreet repo
  4. referenced it in webpack config. try locally built aframe #871

@vincentfretin
Copy link
Collaborator

I don't see any commit in your branch, can you push the change you made?

@rahulkgupta
Copy link
Collaborator Author

@vincentfretin
Copy link
Collaborator

Thanks.
Did you deployed to staging environment? Do you have posthog for the staging environment to see one of the video capture? It's still black?
I don't think we have sessions send to posthog for local environment, right?

@rahulkgupta
Copy link
Collaborator Author

i updated posthog to capture local development. speaking of which, i should probably turn that off now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do - High Prio
Development

No branches or pull requests

3 participants