Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Right panel not properly updated on new/load scene #819

Open
vincentfretin opened this issue Aug 31, 2024 · 2 comments
Open

Right panel not properly updated on new/load scene #819

vincentfretin opened this issue Aug 31, 2024 · 2 comments
Assignees
Labels

Comments

@vincentfretin
Copy link
Collaborator

Steps:

  • load a scene
  • select environment layer
  • open right panel
  • click new scene button

Issue: The right panel still show old data for street-environment component.

Solution: The right panel needs to refresh on newScene event.

@vincentfretin
Copy link
Collaborator Author

I tried to forceUpdate on newScene event in Sidebar, but that didn't work. I think the panel is still showing the removed environment entity, but changing the environment preset is still working, weird.
I reproduce the issue with creating an entity, like putting a bus and showing the right panel, then load another scene, the right panel will still show the bus.
I think more generally the issue here is that the right panel should close when an entity is unselected (or removed), we have the same issue with aframe-inspector, when you press Esc, the entity unselect in the viewport but is still selected in the scene graph and showing properties in the right panel.

@vincentfretin vincentfretin changed the title Right panel not properly updated on new scene Right panel not properly updated on new/load scene Sep 2, 2024
@vincentfretin vincentfretin self-assigned this Sep 2, 2024
@vincentfretin
Copy link
Collaborator Author

Related to this, the blue select box stays instead of disappearing when you load an other scene.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: To Do - High Prio
Development

No branches or pull requests

1 participant