Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

error to undo material texture src change #840

Open
kfarr opened this issue Sep 5, 2024 · 5 comments · Fixed by #842
Open

error to undo material texture src change #840

kfarr opened this issue Sep 5, 2024 · 5 comments · Fixed by #842
Assignees

Comments

@kfarr
Copy link
Collaborator

kfarr commented Sep 5, 2024

[object HTMLImageEleme...] instead of #actual-id after undo of texture change

error-undo-texture-change.mov
@vincentfretin
Copy link
Collaborator

Probably related to the entity serialization for asset properties. We did a fix related to that in aframe master aframevr/aframe#5544
Let's see if we can make a workaround just to fix it without updating to aframe master.

@vincentfretin
Copy link
Collaborator

If in index.html you use an aframe master build (three r167)
<script src="https://cdn.jsdelivr.net/gh/aframevr/aframe@4142ec90a76916d252e375ceb1595971ee264966/dist/aframe-master.min.js"></script>
the issue is fixed.
Really we should just update aframe, not worth the time to try to fix that in an old version.

@vincentfretin
Copy link
Collaborator

#842

@vincentfretin
Copy link
Collaborator

We can do a custom 1.5.0 build with just the change from aframevr/aframe#5544 that should be safer.
I looked at the code, that's not possible to monkey patch propertyTypes, this object is not exposed.

@kfarr kfarr closed this as completed in #842 Sep 9, 2024
@kfarr kfarr closed this as completed in 1552b2e Sep 9, 2024
@vincentfretin
Copy link
Collaborator

Reoponed because we reverted the aframe update in #850 and pending a fix for #851 before updating it again.

@vincentfretin vincentfretin reopened this Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: To Do - High Prio
Development

Successfully merging a pull request may close this issue.

2 participants