Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Moving Deployment to Github Pages #371

Open
shahdivyank opened this issue Dec 18, 2023 · 1 comment
Open

Moving Deployment to Github Pages #371

shahdivyank opened this issue Dec 18, 2023 · 1 comment

Comments

@shahdivyank
Copy link
Contributor

shahdivyank commented Dec 18, 2023

Open to Discussion BTW:

Some benefits to migrating to Github Pages from Netlify:

  1. Deployment and codebase are all within the Github Repo
  2. Remove any costs (not sure if Netlify is purchased currently)
  3. Manage deployment process with Github Actions

Some things to consider:

  1. We have 4 API routes which is not supported with Next.js SSG, but these API routes are simply calling other APIs which means we can make these API calls in the frontend
  2. If we wanted to add custom APIs later on, we would have to revert to Netlify or a similar service
  3. Need to explore how Git LFS would integrate if at all

Anyone have any thoughts/insight on the current deployment process and potentially migrating or against migration for particular reasons?

@vincerubinetti
Copy link
Collaborator

I would vote against this (for now).

  • GitHub Pages does not have PR previews. They were planning to add it, and I thought they would quickly to take business from Netlify, but recently they said it's not coming in the near future. There is rossjrw/pr-preview-action, but it can be a pain with differences between PR and production deploys. For smaller apps, it's usually fine to keep Netlify just for PR previews and deploy production to gh-pages. But for a site this big I would worry about insidious bugs due to deploying those two in separate environments. Looking through the code, there seems to be several things that hook into Netlify specifically.
  • We're currently using Netlify forms. It's a bit of work/cost to set up and keep an eye on a separate server or serverless/cloud functions to do this ourselves.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants