Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upload Container modal no longer warns if revision tag is already in use #5331

Open
sanmont3drepo opened this issue Jan 3, 2025 · 0 comments
Assignees

Comments

@sanmont3drepo
Copy link
Contributor

Description

Product issue: https://github.com/3drepo/3D-Repo-Product-Team/issues/636

The user does not receive a warning that a revision by that tag already exists when using the upload modal. I think it might stem from this PR #5229

  • This is happening in: prod/staging/both
  • This requires a hotfix to production: yes/no

Stakeholders

Steps to replicate

  • Navigate to containers
  • Click on "Upload files" (uploading a file by clicking on upload new revision on elipsis menu works)
  • Add a file
  • Set the destination of the file
  • Change the revision tag to match one that already exists on that destination container

Current Behaviour

  • No error is thrown.
  • The user can attempt to upload the file which will fail

Expected Behaviour

  • An error is thrown which disables the submit button

Pictures/ Gifs of the error

image

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants