-
-
Notifications
You must be signed in to change notification settings - Fork 263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DataStack initializer crashes our app #586
Comments
Hello @vandadnp, You're right, the app shouldn't crash, it should fail gracefully sending an error saying "Free up some space to continue." |
We might need to change this to be a throwable init which will make it a breaking change |
@3lvis thanks for your reply and thank you for Sync 😊 |
@3lvis would you like me to have a look at this and send a PR? |
@vandadnp I'm sorry for the lack of follow up, been drowning in other projects, please, if you're ok with it, happy to receive contributions |
Hi @3lvis I've looked at this and it seems like I have to introduce, as you said, some breaking changes. Should I sent the PR anyways? |
@3lvis I sent the PR for your review |
Describe the bug
We got a crash report in Crashlytics today stating the following:
This is occurring on a telephone that doesn't have enough space to create a new DataStack and we have no initializers for DataStack that throws an error since there are a lot of explicitly unwrapped code like this:
To Reproduce
Steps to reproduce the behavior:
Expected behavior
The app shouldn't crash
iOS Version (please complete the following information):
14.2.0
Framework Version (please complete the following information):
The text was updated successfully, but these errors were encountered: