install in directory where parent directory has spaces

[julianbrowne]

There seems to be a known issue with node-gyp and installing in directories where the parents directories contain spaces: nodejs/node-gyp#65.
This certainly seems to be my case (works without spaces, fails with).
The problem is in binding.gyp at:

'include_dirs': ["<!(node -p -e \"require('path').dirname(require.resolve('nan'))\")"]

A simple string replace in the node script looks to fix it:

{
  "targets": [
    {
      "target_name": "hashvalue",
      'include_dirs': ["<!(node -p -e \"require('path').dirname(require.resolve('nan')).replace(/ /g, '\\\\\ ')\")"],
      "sources": [ "src/hashvalue.cc" ]
    }
  ]
}

[3rd-Eden]

Is there any way we could write test against this?

[julianbrowne]

Or (just a thought) - that line is only there to find nan.h, which is always installed by npm relative to binding.gyp at node_modules/nan. So this works without any executable code at all:

{
  "targets": [
    {
      "target_name": "hashvalue",
      "include_dirs": ["node_modules/nan"],
      "sources": [ "src/hashvalue.cc" ]
    }
  ]
}

Better?