Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub action request #13

Open
ArthurBandaryk opened this issue Dec 9, 2021 · 3 comments
Open

GitHub action request #13

ArthurBandaryk opened this issue Dec 9, 2021 · 3 comments

Comments

@ArthurBandaryk
Copy link
Contributor

For now we have a number of repos, some private some public, close to all of them bazel ones. On each of them we'd like to easily do a build check and run all tests before merging. To avoid having to have to copy code around or manually tweak target names (e.g. bazel test test:eventuals only works in eventuals) from repo to repo or every time it updates, it would be nice to have a generic github action that:

  • Checks if this is a bazel repo (perhaps by looking for a BUILD.bazel or similar).
  • If so, determines all the possible build and test targets in the repo (not just directory).
  • Tries to bazel build (and/or bazel test ) every target.

This would allow us to create branch protection rules that does not depend on the individual repo, and the action can live in one isolated place making it easier to maintain and update.

@ArthurBandaryk
Copy link
Contributor Author

@while-false , am I missing something?

@while-false
Copy link
Contributor

while-false commented Dec 9, 2021

@while-false , am I missing something?

All good - it indeed looks very much like my feature request! Thanks for creating this issue @ArthurBandaryk and for taking it on!

@benh
Copy link
Member

benh commented Dec 9, 2021

I love this!

Testing is probably a bit easier, we can have a generic :test target. But I don't see why we couldn't also have a :build too! Of course, I'd really prefer that :test actually builds everything that you'd get from :build, but unfortunately somethings really aren't tested, like main.cc of binaries.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants