We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
std::chrono::duration
::eventuals::Timer() takes a std::chrono::milliseconds:
::eventuals::Timer()
std::chrono::milliseconds
eventuals/eventuals/timer.h
Line 11 in d423018
But it's just a pass-through to Clock().Timer(), which instead takes a std::chrono::nanoseconds:
Clock().Timer()
std::chrono::nanoseconds
eventuals/eventuals/event-loop.h
Lines 1283 to 1284 in d423018
We should standardize on one type type for timers.
We probably should also pass std::chrono::duration types by value, not const&: https://stackoverflow.com/questions/37918168/pass-stdchronoduration-by-value-or-by-reference-to-const since they're essentially backed by ~ints by default: https://en.cppreference.com/w/cpp/chrono/duration
The text was updated successfully, but these errors were encountered:
No branches or pull requests
::eventuals::Timer()
takes astd::chrono::milliseconds
:eventuals/eventuals/timer.h
Line 11 in d423018
But it's just a pass-through to
Clock().Timer()
, which instead takes astd::chrono::nanoseconds
:eventuals/eventuals/event-loop.h
Lines 1283 to 1284 in d423018
We should standardize on one type type for timers.
We probably should also pass
std::chrono::duration
types by value, not const&: https://stackoverflow.com/questions/37918168/pass-stdchronoduration-by-value-or-by-reference-to-const since they're essentially backed by ~ints by default: https://en.cppreference.com/w/cpp/chrono/durationThe text was updated successfully, but these errors were encountered: